fix(logger, wrapper): support csv file and velocity tasks #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaiejj
requested review from
zmsn-2077 and
friedmainfunction
and removed request for
zmsn-2077
zmsn-2077
reviewed
Mar 5, 2023
omnisafe/common/logger.py
Outdated
| print('project', project, 'name', name) | ||
| wandb.init(project=project, name=name, dir=self._log_dir, config=config) | ||
| project: str = self._config.get('wandb_project', 'omnisafe') | ||
| name: str = self._config.get('wandb_name', f'{exp_name}/{relpath}') |
zmsn-2077
reviewed
Mar 5, 2023
omnisafe/common/logger.py
Outdated
| @@ -142,12 +144,11 @@ def __init__( # pylint: disable=too-many-arguments,too-many-locals | |||
|
|
|||
| if self._use_tensorboard and self._maste_proc: | |||
| self._tensorboard_writer = SummaryWriter(log_dir=os.path.join(self._log_dir, 'tb')) | |||
|
|
|||
| if self._use_wandb and self._maste_proc: | |||
zmsn-2077
approved these changes
Mar 5, 2023
zmsn-2077
pushed a commit
to zmsn-2077/omnisafe_zmsn
that referenced
this pull request
Mar 14, 2023
zmsn-2077
pushed a commit
to zmsn-2077/omnisafe_zmsn
that referenced
this pull request
Mar 14, 2023
zmsn-2077
pushed a commit
to zmsn-2077/omnisafe_zmsn
that referenced
this pull request
Mar 14, 2023
zmsn-2077
pushed a commit
that referenced
this pull request
Mar 14, 2023
zmsn-2077
pushed a commit
that referenced
this pull request
Mar 15, 2023
zmsn-2077
added a commit
that referenced
this pull request
Mar 18, 2023
Co-authored-by: borong <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ruiyang sun <[email protected]> Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: friedmainfunction <[email protected]> Co-authored-by: Gaiejj <[email protected]> Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: Ruiyang Sun <[email protected]> Co-authored-by: Jiayi Zhou <[email protected]> Co-authored-by: 1Asan <[email protected]> fix(algo): fix no return in algo_wrapper::learn (#122) fix(logger, wrapper): support csv file and velocity tasks (#131) fix typo. (#134) fix(ppo): fix entropy loss (#135) fix bugs (#136) fix: support new config for exp_grid (#142) fix(rollout, exp_grid): fix logdir path conflict (#145) fix(on-policy): fix the second order algorithms performance (#147)
15 tasks
zmsn-2077
added a commit
that referenced
this pull request
Mar 19, 2023
Co-authored-by: borong <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ruiyang sun <[email protected]> Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: friedmainfunction <[email protected]> Co-authored-by: Gaiejj <[email protected]> Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: Ruiyang Sun <[email protected]> Co-authored-by: Jiayi Zhou <[email protected]> Co-authored-by: 1Asan <[email protected]> fix(algo): fix no return in algo_wrapper::learn (#122) fix(logger, wrapper): support csv file and velocity tasks (#131) fix typo. (#134) fix(ppo): fix entropy loss (#135) fix bugs (#136) fix: support new config for exp_grid (#142) fix(rollout, exp_grid): fix logdir path conflict (#145) fix(on-policy): fix the second order algorithms performance (#147)
zmsn-2077
added a commit
that referenced
this pull request
Mar 26, 2023
Co-authored-by: borong <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ruiyang sun <[email protected]> Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: friedmainfunction <[email protected]> Co-authored-by: Gaiejj <[email protected]> Co-authored-by: zmsn-2077 <[email protected]> Co-authored-by: Ruiyang Sun <[email protected]> Co-authored-by: Jiayi Zhou <[email protected]> Co-authored-by: 1Asan <[email protected]> fix(algo): fix no return in algo_wrapper::learn (#122) fix(logger, wrapper): support csv file and velocity tasks (#131) fix typo. (#134) fix(ppo): fix entropy loss (#135) fix bugs (#136) fix: support new config for exp_grid (#142) fix(rollout, exp_grid): fix logdir path conflict (#145) fix(on-policy): fix the second order algorithms performance (#147)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(logger, wrapper): support csv file and velocity tasks
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format. (required)make lint. (required)make testpass. (required)